Skip to content

Interop: E2E cross l2 inbox#12268

Closed
axelKingsley wants to merge 5 commits intodevelopfrom
interop/E2E-CrossL2Inbox
Closed

Interop: E2E cross l2 inbox#12268
axelKingsley wants to merge 5 commits intodevelopfrom
interop/E2E-CrossL2Inbox

Conversation

@axelKingsley
Copy link
Copy Markdown
Contributor

@axelKingsley axelKingsley commented Oct 2, 2024 •
edited by protolambda
Loading

This PR:

  • Implements the manual binding for CrossL2Inbox.ExecuteMessage
  • Implements the creation of an identifier based on past messages
  • Calls the Execute Message binding with the identifier

These expanded behaviors let us test interop in E2E, specifically allowing us to emit executing messages.

This PR isn't fully functional yet, as calling the function and awaiting the receipt creates a context.deadline.exceeded. I also found similar behavior when calling the op-geth client BlockByHash, so I think something is closing when not intended.

Based on top of #12427

@axelKingsley axelKingsley force-pushed the interop/E2E-CrossL2Inbox branch from 8d4774e to 91fe966 Compare October 2, 2024 20:13
@semgrep-app
Copy link
Copy Markdown
Contributor

semgrep-app bot commented Oct 4, 2024

Semgrep found 138 sol-style-require-reason findings:

require() must include a reason string

Ignore this finding from sol-style-require-reason.

Semgrep found 2 sol-style-notice-over-dev-natspec findings:

  • packages/contracts-bedrock/scripts/fpac/viz/FaultDisputeGameViz.s.sol

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 4 sol-style-doc-comment findings:

Javadoc-style comments are not allowed. Use /// style doc comments instead.

Ignore this finding from sol-style-doc-comment.

@axelKingsley axelKingsley force-pushed the interop/integrate-views-input branch from e43a260 to a98e033 Compare October 4, 2024 19:23
protolambda
protolambda reviewed Oct 7, 2024
View reviewed changes
@protolambda protolambda force-pushed the interop/integrate-views-input branch from a98e033 to fe6ea01 Compare October 8, 2024 14:55
@semgrep-app
Copy link
Copy Markdown
Contributor

semgrep-app bot commented Oct 9, 2024

Semgrep found 2 sol-style-require-reason findings:

require() must include a reason string

Ignore this finding from sol-style-require-reason.

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/scripts/deploy/ChainAssertions.sol

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 2 sol-style-malformed-revert findings:

  • packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • packages/contracts-bedrock/scripts/deploy/Deploy.s.sol

Malformed revert statement style.

Ignore this finding from sol-style-malformed-revert.

Semgrep found 1 sol-style-doc-comment finding:

  • packages/contracts-bedrock/src/safe/SafeSigners.sol

Javadoc-style comments are not allowed. Use /// style doc comments instead.

Ignore this finding from sol-style-doc-comment.

Semgrep found 13 sol-style-malformed-require findings:

  • packages/contracts-bedrock/src/cannon/PreimageOracle.sol
  • packages/contracts-bedrock/scripts/periphery/deploy/DeployPeriphery.s.sol
  • packages/contracts-bedrock/scripts/libraries/DeployUtils.sol
  • packages/contracts-bedrock/scripts/deploy/DeployOwnership.s.sol
  • packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • packages/contracts-bedrock/scripts/deploy/Deploy.s.sol
  • packages/contracts-bedrock/scripts/deploy/ChainAssertions.sol
  • packages/contracts-bedrock/scripts/autogen/SemverLock.s.sol
  • packages/contracts-bedrock/scripts/DeploySuperchain.s.sol

"challenge period too large" Malformed require statement style.

Ignore this finding from sol-style-malformed-require.

@protolambda protolambda changed the base branch from interop/integrate-views-input to interop-cleanup October 11, 2024 15:24
@protolambda protolambda force-pushed the interop/E2E-CrossL2Inbox branch from 48e7d78 to d872f65 Compare October 11, 2024 15:25
@semgrep-app
Copy link
Copy Markdown
Contributor

semgrep-app bot commented Oct 11, 2024

Semgrep found 2 golang_fmt_errorf_no_params findings:

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

@axelKingsley axelKingsley force-pushed the interop-cleanup branch 2 times, most recently from 320d742 to 0cc2e9a Compare October 15, 2024 21:15
Base automatically changed from interop-cleanup to develop October 15, 2024 22:53
@protolambda
Copy link
Copy Markdown
Contributor

protolambda commented Oct 31, 2024

This PR is stale. I continued the integration of cross-l2-inbox here and added you as co-author. Sorry about that, but a lot changed since this PR was drafted: #12754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@protolambda protolambda protolambda left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@axelKingsley @protolambda @tcrypt25519